update Rust to 1.87.0 #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the panic strategy to "abort" for custom targets, since we expect that Rust crates for Bottlerocket will be written to avoid panics, and don't want to pay the cost in binary size to support unwinding. This lets us avoid specifying the "abort" behavior in Cargo.toml at the crate or workspace level, so that release builds using the normal targets on developer systems will default to "unwind", which can be helpful for debugging. Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Otherwise cargo emits this warning: warning: `.../.cargo/config` is deprecated in favor of `config.toml` Signed-off-by: Ben Cressey <[email protected]>
jmt-lab
approved these changes
May 22, 2025
arnaldo2792
reviewed
May 23, 2025
Dockerfile
Outdated
| @@ -285,7 +285,7 @@ RUN \ | |||
|
|
|||
| ARG HOST_ARCH | |||
| ENV VENDOR="bottlerocket" | |||
| ENV RUSTVER="1.85.1" | |||
| ENV RUSTVER="1.86.0" | |||
There was a problem hiding this comment.
Do you need to keep the commits that bump 1.85.0 -> 1.85.1 -> 1.86.0 -> 1.87.0?
There was a problem hiding this comment.
I kept them to show the progression, and in case we needed to revert 1.87.0 at the last minute without necessarily backing out the other changes. 1.85.1 is useful as it lets us drop the cc-rs patch.
This was referenced May 27, 2025
|
Marking as ready for review now that the downstream clippy fixes have been merged. |
KCSesh
approved these changes
May 31, 2025
arnaldo2792
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #272
Description of changes:
Update Rust to 1.87.0.
Set the panic strategy to "abort" for all custom targets. This preserves unwinding for developer builds outside of the SDK, where the custom targets are not available, while reducing the disk usage and runtime overhead for production builds.
Testing done:
Built kits and smoke-tested variants for both architectures.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.